oxidecomputer / oxidecomputer/omicron
should `tools/update_lldp.sh` update lldpd_client, lldpd_protocol crates?
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
See #10361. The fix (in #10220) includes putting the SHAs into Cargo.toml for these packages. Should ./tools/update_lldp.sh be doing that for us?
Originally posted by @sunshowers in https://github.com/oxidecomputer/omicron/pull/10220#discussion_r3590952838
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tools/update_lldp.sh and the Cargo.toml entries for lldpd_client and lldpd_protocol. Read the related context in #10361 and #10220, then determine whether the script should update those package SHAs as part of its existing workflow. Done means the script behavior and both Cargo.toml entries are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust, shell
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 67/100