oxidecomputer / oxidecomputer/omicron
Does BgpAnnouncement need address_lot_block_id?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Can we file an issue for this for the networking folks to weigh in?
Originally posted by @jgallagher in https://github.com/oxidecomputer/omicron/pull/10653#discussion_r3494481546
BgpAnnouncement has the shape:
#[derive(
Queryable, Insertable, Selectable, Clone, Debug, Serialize, Deserialize,
)]
#[diesel(table_name = bgp_announcement)]
pub struct BgpAnnouncement {
pub announce_set_id: DbTypedUuid<BgpAnnounceSetKind>,
pub address_lot_block_id: Uuid,
pub network: IpNetwork,
}
From what I can tell it doesn't look like address_lot_block_id is used anywhere. Is this something we still need? Also it seems like this is the same as the BGP announcement set ID. Is that intentional?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the BgpAnnouncement definition and the discussion in pull request #10653, then search for all references to address_lot_block_id and announce_set_id. Confirm whether the fields represent distinct data and document or implement the networking team's decision, including any affected schema or callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100