oxidecomputer / oxidecomputer/omicron
Remove infra_ip_first and infra_ip_last from UserSpecifiedRackNetworkConfig and RackNetworkConfig
Open
Nobody has claimed this yet.
multi-rack
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
These are unused except for validation in wicket. This is overly constraining as pointed out in a comment in the type:
// TODO: #3591 Consider making infra-ip ranges implicit for uplinks
/// First ip address to be used for configuring network infrastructure
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Rust definitions of UserSpecifiedRackNetworkConfig and RackNetworkConfig, then trace the validation in wicket and the references to infra_ip_first and infra_ip_last. Confirm which callers and checks depend on these fields; done means the unused fields and their validation are removed without leaving compilation or test failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100