oxidecomputer / oxidecomputer/omicron
Should 400 if trying to set a block size on a local disk
Open
Beginner friendly
Nobody has claimed this yet.
api
local storage
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Local disks have a hard-coded block size, so passing block_size at create time does nothing. Instead of ignoring it, we should error out at create time if a block size other than 4096 is passed in.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked logic in nexus/src/app/sagas/disk_create.rs and nexus/src/app/disk.rs, focusing on how block_size is handled for local disks. Trace the create-time request path and identify the existing validation or error response conventions. Done means a local-disk request with any block_size other than 4096 returns HTTP 400 instead of being silently accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100