oxidecomputer / oxidecomputer/omicron
Add stats related to NVMe Discard
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
With the support of NVMe Discard operations introduced by https://github.com/oxidecomputer/propolis/pull/1105, we should add Oximeter stats related to these operations, to match https://github.com/oxidecomputer/omicron/blob/main/oximeter/oximeter/schema/virtual-disk.toml:
- discards
- failed-discards
- add this to io-latency and io-size and make sure this is a new io-kind of operation
(thanks to @rmustacc for these details)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the existing Oximeter virtual-disk metrics with oximeter/oximeter/schema/virtual-disk.toml and review the NVMe Discard support introduced in propolis PR 1105. Trace the corresponding Rust metric definitions and tests, then verify that discards and failed-discards are reported, discard is included in io-latency and io-size, and it uses a distinct io-kind.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100