oxidecomputer / oxidecomputer/omicron
Audit log: include GET endpoints in the audit log
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The audit log right now only tracks state-changing operations (POST), and it does not include read-only operations (GET), such as listing resource details. Including those read-only endpoints in the audit log will be important for some customers. Things like resource names and the audit log itself are, or can be, considered sensitive information, and so users getting that information may considered to have relevant security implications, and therefor needed / expected in the audit log. Additionally, this information can be useful for modeling typical user behavior, where some customers maybe want to build signals from in order to detect anomalous activity.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the audit-log handling for POST operations and the GET endpoint definitions, then determine how read-only requests should be recorded. Done means relevant GET operations, including sensitive resource reads and audit-log reads, appear in the audit log with sufficient request context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100