oxidecomputer / oxidecomputer/omicron
Increase MGS_UPDATE_SETTLE_TIMEOUT to give updates more leeway to complete
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The phase 1 image update on a Cosmo takes ~4 minutes, and currently MGS_UPDATE_SETTLE_TIMEOUT gives us 5 minutes to execute the update. Should anything delay the blueprint execution, such as one or most sleds being down, each of which will add a 60 second delay, this will push us over the deadline.
@jgallagher suggested increasing MGS_UPDATE_SETTLE_TIMEOUT to 10 or 15 minutesNexus was frequently taking several minutes to start executing the blueprints it had created for an update.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for MGS_UPDATE_SETTLE_TIMEOUT and inspect how the phase 1 image update timeout is applied in the Nexus blueprint execution path. Confirm the timeout is increased enough to cover the roughly four-minute update plus delays from unavailable sleds, and run the relevant update or blueprint tests if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100