oxidecomputer / oxidecomputer/omicron
SpComponentDetails should include LastPostCode and GpioToggleCount
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
With #9354 we pulled in the LastPostCode and GpioToggleCount into SpComponentDetails types from MGS, but fail to convert them into SpComponentDetails. This has impacted downstream clients like omdb mgs sensors.
We should handle these new types gracefully, but updating SpComponentDetails will require either pinning sled-agent on the 1.0.0 MGS API, or a fix for https://github.com/oxidecomputer/omicron/issues/9708.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with gateway-types/versions/src/impls/component_details.rs, especially the linked LastPostCode and GpioToggleCount definitions, and trace the conversion into SpComponentDetails. Check the downstream omdb mgs sensors usage and issue #9708 before choosing between pinning sled-agent to the 1.0.0 MGS API or applying the compatibility fix. Done means both fields are converted without breaking downstream clients.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100