oxidecomputer / oxidecomputer/omicron
`ZpoolHealth`: Don't implement `FromStr`
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
I agree with replacing FromStr. That looks like it's parsing the CLI tool output format.
Originally posted by @bnaecker in https://github.com/oxidecomputer/omicron/pull/10158#discussion_r2996222364
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Rust definition of ZpoolHealth and its FromStr implementation, then inspect the callers and tests that rely on parsing it. Confirm what replaces the CLI-output parsing path before removing the implementation; done means the type no longer implements FromStr and affected tests or callers remain valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100