oxidecomputer / oxidecomputer/omicron
Static route `nexthop` addresses: Consider stronger types
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
#10082 introduces newtype wrappers around IpAddr and IpNet for BGP peer and local uplink addresses that reject a variety of classes of IPs (multicast, localhost, etc.). @taspelund noted we could and should apply these same restrictions to nexthop addresses in static routes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing issue #10082 and the newtype wrappers it introduced for BGP peer and local uplink addresses. Locate the static-route nexthop address types and their tests, then confirm that the same rejected IP classes are enforced for nexthops.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100