oxidecomputer / oxidecomputer/omicron
ereport filters need to include part numbers if querying by serials
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
I am realizing that the way we are currently querying for ereports by serial is a bit wrong. V1 serials are only guaranteed to be unique within a part number, so we may see (for example) a sled and switch with the same serial. Which means we may get surprising results from an ereport query --- if the user wanted to get ereports from 0XV1:913-0000019:4:BRM42000069 (a Gimlet) and the rack also contained OXV1:913-0000003:2:BRM42000069 (a PSC), they might be somewhat surprised to discover that the bundle they requested of the Gimlet's ereports also has a bunch of "rectifier inserted and removed here" ereports from the PSC. So, we should probably change the way we query ereports by serial to also include the CPN. Sigh. This one's my fault.
Originally posted by @hawkw in https://github.com/oxidecomputer/omicron/pull/10108#discussion_r2967057940
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the ereport query entry point and the serial-filtering logic; verify how a serial is parsed and matched, then confirm that queries for a serial only return ereports for the requested part number (CPN), including coverage for duplicate serials across parts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100