oxidecomputer / oxidecomputer/omicron

Include network interfaces in instance response (no pagination needed)

Open
#1,009 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api nexus
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

I believe there's a maximum of 8 or 6 or some small number, so there's no need to paginate.

https://github.com/oxidecomputer/omicron/blob/810301c3aa15cf297a95b6880824f21c0ee9aca1/nexus/src/external_api/http_entrypoints.rs#L1475-L1488

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at nexus/src/external_api/http_entrypoints.rs lines 1475-1488 and trace how the instance response is assembled. Check the existing API response types and related tests before determining where network interfaces belong. Done means the instance response includes its network interfaces without pagination and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.