oxidecomputer / oxidecomputer/netadm-sys

Audit ioctl usage

Open
#20 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
7
Forks
4
PR merge metrics
No merged PRs in 30d

Description

In PR #18 we fixed a few problematic forms of UB involving ioctl calls. But we need to more comprehensively audit ioctl usage to ensure that other instances of UB do not creep in. Specifically, the ioctl_ro may be a bit of a foot gun and should get further thought.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing PR #18 and auditing the repository's ioctl call sites, with particular attention to ioctl_ro. Compare each use against the problematic forms fixed in that pull request. Done means the ioctl usage has been comprehensively reviewed and any additional undefined-behavior risks or ioctl_ro foot guns have a decided resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking, operating-systems
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.