oxidecomputer / oxidecomputer/maghemite

External peer address objects could have a better type than `string`

Open
#914 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ddm
Dominant language
Rust
Stars
94
Forks
6
Avg merge
1d 8h
Merged PRs (30d)
12

Description

Per this review comment.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the review discussion linked in the issue, since it contains the stated rationale and intended direction. Then locate the external peer address objects and how their addresses are represented. Done means the agreed stronger type replaces the current string representation and the affected behavior remains covered by the project's tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.