oxidecomputer / oxidecomputer/maghemite
MD5 setup does not account for configured source/bind address in outbound connections
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
BgpConnectionTcp::connect creates a TCP socket and then spawns a connector thread which optionally does a bind(), tries to connect(), and applies the TTL/hop-limit settings to the socket.
However, MD5 is setup before the bind() call and doesn't consider the Option holding the bind address.
This means that if a bind address is configured, the MD5 SAs will be setup using the wrong local address and thus MD5 won't actually be applied.
Note: this affects Illumos only, since Linux simply applies MD5 via a setsockopt rather than requiring SAs with local/remote IP/port information.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at BgpConnectionTcp::connect and trace the connector thread through bind(), connect(), and the Illumos-specific MD5 setup. Verify how the Option stores the configured source/bind address, then ensure outbound MD5 uses that address while Linux behavior remains unchanged. Done means MD5 is applied correctly for configured bind addresses on Illumos.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100