oxidecomputer / oxidecomputer/maghemite

Finish transition to DDM protocol version 3

Open
#774 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
94
Forks
6
Avg merge
1d 8h
Merged PRs (30d)
12

Description

We have implemented protocol version 3, but are still on version 2

https://github.com/oxidecomputer/maghemite/blob/6542c37075c4c95cacc84ee2289ff383d70f5ae2/ddm/src/discovery/runtime.rs#L50-L66

When we make the switch, we need to consider the concerns in

  • #157
  • #275

In particular our backwards compatibility tests no longer exist. The were very messy, served no purpose when v1 ceased to exist, and it was decided that re-introducing backwards compatibility tests should have a fresh start on a second attempt at the dawn ov v3. So now here we are.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in ddm/src/discovery/runtime.rs around lines 50-66 to trace the current protocol-version selection. Read issues #157 and #275 for the compatibility concerns, then determine the fresh-start backwards-compatibility tests needed for version 3. Done means the runtime switches from version 2 to version 3 and the relevant compatibility coverage is restored.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.