oxidecomputer / oxidecomputer/maghemite
BGP: consider filling in support for disabled keepalives
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
Currently during OPEN negotiation, there is no handling for a hold time of 0 which disables keepalives (per RFC 4271).
We should consider fixing this by adding proper support for it into the OPEN handling logic, and updating the FSM to ensure keepalive/hold timers are disabled (and thus the FSM events for their timers firing are also disabled).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the OPEN negotiation handling and the FSM, focusing on the hold-time value of 0 described in RFC 4271. Trace how keepalive and hold timers are configured and how their firing events enter the FSM; done means both timers and their firing events are disabled for a zero hold time, with tests covering the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100