oxidecomputer / oxidecomputer/maghemite
Remove serde flatten for bgp parameters in external API
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
Per this comment
https://github.com/oxidecomputer/maghemite/pull/584#discussion_r2775097424
This causes all of these fields to be duplicated in the progenitor client, which leads to some kinda painful duplication (e.g., https://github.com/oxidecomputer/omicron/blob/8186a1d914d4297136eb0892a3881a38dc9fc68b/sled-agent/src/bootstrap/early_networking.rs#L570-L605 and https://github.com/oxidecomputer/omicron/blob/8186a1d914d4297136eb0892a3881a38dc9fc68b/sled-agent/src/bootstrap/early_networking.rs#L617-L654).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read bgp/src/params.rs around lines 156-165 and the linked pull request discussion first. Check how the BGP parameter fields are represented in the external API and generated progenitor client, then remove the flattening so the client no longer duplicates those fields. Done means the API shape matches the requested representation without breaking related consumers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 57/100