oxidecomputer / oxidecomputer/maghemite
bgp: making enforce_first_as config handler more graceful
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
Right now a change to enforce-first-as will cause a hard reset of the session. This could be much more graceful, given it is a policy change and not a session parameter change.
disabled -> enabled should trigger a rib walker that deletes all paths from the updated peer that fail the first-as check.
enabled -> disabled should trigger a route refresh (since we don't store unmodified routes in the adj-rib-in).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the enforce_first_as configuration handler and trace how the current change causes a session hard reset. Then inspect the existing RIB walker and route-refresh paths. Done means disabling the setting removes affected peer paths that fail the first-AS check, while enabling it triggers a route refresh without resetting the session.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100