oxidecomputer / oxidecomputer/maghemite
bgp: consolidate dual-stack logic where possible
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
In the MP-BGP PR, we are adding code that has separate types for v4/v6 but with per-AF impls. There are many cases where the logic is effectively the same for both paths (even down to struct member/method names) and that could be consolidated (e.g. making some things generic).
So this would be a nice cleanup to pursue when there's time.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MP-BGP implementation and compare the separate v4/v6 types and per-AF implementations, especially members and methods with identical names. Identify candidates for generic or shared logic and confirm behavior remains equivalent across both address families. Done means duplicated logic is consolidated where practical without changing BGP behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100