oxidecomputer / oxidecomputer/maghemite

mg-ddm appears to emit both plaintext and bunyan-format logs

Open
#350 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
94
Forks
6
Avg merge
1d 8h
Merged PRs (30d)
12

Description

Elsewhere we use bunyan-format logs, which are JSON entries that looker can read. In some places (some dev tools) we have configured slog to emit a plaintext format. mg-ddm appears to do both of these. Here's a snippet from a file:

{"msg":"[vioif2] removing 0 routes from illumos","v":0,"name":"slog-rs","level":30,"time":"2024-08-27T17:18:48.458201847Z","hostname":"g3","pid":1339}
Aug 27 17:23:04.670 DEBG client request, body: Some(Body), uri: http://[fd00:1122:3344:102::5]:12221/metrics/producers, method: POST, component: producer-registration-task

The plaintext output makes it much harder to do things like filtering on log level with looker.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the mg-ddm logging setup and reproduce the mixed output shown in the issue. Trace where the bunyan-format and plaintext configurations are selected; done means mg-ddm emits one consistent format that looker can parse and filter by log level.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.