oxidecomputer / oxidecomputer/maghemite
ddm: `enable_stats` smashes all errors into 500s
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 94
- Forks
- 6
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 12
Description
This code smashes all errors to the enable_stats endpoint into 500s.
It would be helpful to be more specific here, in particular if the underlay configuration has not gotten far enough along yet to enable stats, we'll probably want to return something more like a 503.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ddm/src/admin.rs around lines 382-386, where errors from the enable_stats endpoint are converted into HTTP 500 responses. Trace the errors that can occur when underlay configuration is not ready, and make the endpoint return more specific status codes, including 503 for that unavailable state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100