oxidecomputer / oxidecomputer/lmar
LMAR does not appear to do anything with error count limits
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The set_error_count_limit function is commented out everywhere it is called so it is not clear what error count limit is being used and it does not seem like that can be overridden on the command line like it should be able to.
Per PCIe spec (Gen 5, revision 1, section 4.2.13.2, page 402), if there is no limit set, the default value is 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the commented-out set_error_count_limit call sites and the command-line option handling. Check how the current error-count limit is selected, compare the no-limit behavior with the PCIe Gen 5 specification's default of 4, and verify that a command-line override is honored. Done means the limit has a defined default and can be overridden as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100