oxidecomputer / oxidecomputer/iddqd
Make the hashbrown dependency optional
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 405
- Forks
- 15
- Avg merge
- 14m
- Merged PRs (30d)
- 25
Description
I was uncertain whether pull in iddqd for a project where it would be kinda useful, but potentially not worth the cost of the extra dependency. Pulling in hashbrown and rustc-hash definitely pushes it towards "not worth", but it seems like this would be easy to fix? I'm only interested in using IdOrdMap, and would be more than happy to submit a PR feature-gating all the hashmaps if you agree this is a good idea.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the Rust dependency declarations and the hashmap implementations to see how hashbrown and rustc-hash are currently used. Determine the feature boundaries needed so IdOrdMap can be used without those dependencies; done means the optional configuration builds and the existing hashmap functionality remains covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100