oxidecomputer / oxidecomputer/humility
Humility gets the task ordering from the ZIP directory, not the toml
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 584
- Forks
- 63
- Avg merge
- 3h
- Merged PRs (30d)
- 2
Description
More bugs I'm discovering using exhubris tools:
The exhubris tools order the ZIP file entries for the task elf images in elf/task/NAME alphabetically. The original Hubris build system happens to use the TOML declaration order.
It turns out Humility is relying on this in at least some cases for assigning tasks to indices, resulting in a garbled task listing order in commands like tasks (and presumably a misinterpretation of taskids in commands like ipc, but I haven't checked).
The canonical task order is defined in the app.toml file, and this should be the only ordering that's used.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing task ordering in the tasks and ipc commands, comparing the ZIP entry order with the declarations in app.toml. Confirm where task indices are assigned and ensure the canonical TOML declaration order is used consistently; done means task listings and task IDs no longer depend on ZIP ordering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100