oxidecomputer / oxidecomputer/humility
humility qspi -D doesn't always complain when starting address + filesize ends beyond the virtual slot address.
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 584
- Forks
- 63
- Avg merge
- 3h
- Merged PRs (30d)
- 2
Description
This is the result of a 16MB file with a starting address puts some or all of the image outside of the virtual slot.
➜ hubris git:(master) ✗ humility qspi -D RRRT1001C.nanobl-rs.FD -a0x02000000
humility: attached via ST-Link V3
humility: erased 64.00KB in 0 seconds
humility: hashed 16.00MB, wrote 64.00KB in 11 seconds
This should be an error.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the reported humility qspi -D ... -a0x02000000 command and trace the qspi command's address and image-size validation. Done means the command reports an error whenever the starting address plus file size extends beyond the virtual slot address.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100