oxidecomputer / oxidecomputer/humility

Check that the program counter is in our archive

Open
#396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
584
Forks
63
Avg merge
3h
Merged PRs (30d)
2

Description

Calling something like

humility -a build-rot-carrier-image-b.zip tasks

will "work" even if Hubris is executing out of slot A, as long as slot B is programmed with the given image. This is because the RoT slots are absolutely addressed in flash, so "check if the image ID at flash location X matches" passes.

Obviously, all Humility results will be wrong when operating in this regime.

We should check the program counter and make sure we're actually in the executable space of our archive.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the archive validation used by humility -a build-rot-carrier-image-b.zip tasks and trace how the running program location is checked. The fix is done when an archive is rejected if the program counter is outside its executable space, while a matching archive is accepted; verify both cases with the relevant command or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.