oxidecomputer / oxidecomputer/humility
Integer underflow can be triggered by corrupt target stacks
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 584
- Forks
- 63
- Avg merge
- 3h
- Merged PRs (30d)
- 2
Description
https://github.com/oxidecomputer/humility/blob/master/src/hubris.rs#L3016
This subtraction assumes addr is in the region. It is not necessarily in the region, and this crashes the debugger.
Should be fallible (e.g. use checked_sub and return Err)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/hubris.rs:3016 and inspect how the subtraction is handled by the surrounding function. Make the corrupt-target-stack path return an error instead of crashing the debugger, then run the relevant Rust tests or test suite to verify valid stacks still work and invalid addresses are handled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100