oxidecomputer / oxidecomputer/hubris
get address for DICE artifacts from config
Open
@flihp is already working on this.
Since Aug 24, 2022.
trust quorum
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
Our prototype currently hard codes these addresses in the source code. Getting them from the chip.toml at build time would be better. At first look doing so would require adding some plumbing to xtask. The data we would need is in the 'chip' key from the top level toml table but AFAIK the currently available methods for getting at the app toml exposed to tasks at build time aren't sufficient:
build_util::configexposes the app config that includes tables under[config]: https://github.com/oxidecomputer/hubris/blob/09fb9271df0208dc571ade28feb0503c78707817/build/util/src/lib.rs#L50build_util::task_configexposes tables under the[task_name]table: https://github.com/oxidecomputer/hubris/blob/09fb9271df0208dc571ade28feb0503c78707817/build/util/src/lib.rs#L57
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.