oxidecomputer / oxidecomputer/hubris
SPI over HIF should have parameterized offset
Open
Nobody has claimed this yet.
affects-humility
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
Right now, we can't do multiple SPI transactions in a single HIF program, because spi_read/write always use data[0..].
We should parameterize the offset within the data array to make this possible. This probably means adding another argument, which would be a breaking change for Humility as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in task/hiffy/src/common.rs around line 117, where spi_read/write use data[0..], and trace the HIF argument handling. Define the offset parameter so multiple SPI transactions can share one HIF program, then verify the related Humility interface is updated for the breaking argument change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100