oxidecomputer / oxidecomputer/hubris
host-sp-comms: take a second review look at Host Panic/Host Bootfail ereport contents
Open
@jamesmunns is already working on this.
Since Jul 29, 2026.
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
When merging #2518, there was a lot of commentary on the contents of the MGS messages, but not too much on the contents of the relevant ereports:
Looking at this after the fact, @rmustacc pointed a couple of things out, and @jamesmunns noticed:
- We probably don't need the total_len, an event is probably more uniquely identified by the tuple of
(restart_id, seqno), andrestart_iddid not make it into the ereportis implicitly included in all ereports. HostBootFailrenamedseqnotoseq, butHostPanicdidn't. We should probably make this consistent.- We might want to spill a bit more ink on the use of wrapping sequence numbers, and why that is preferable to saturating sequence numbers
- On Host Bootfail, we may want to consider including some amount of POST code history, as we made available in hubris, from the FPGA
We can either bump the version, or potentially just keep version 0 if we make these changes soon, as I don't believe we've cut a release with these ereports yet. It probably doesn't hurt to rev the version either way though.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.