Cosmo is missing `isl68224` temperature

Open Beginner friendly
#2,577 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
rust
Domain
embedded-iot

Research direction

Start at app/cosmo/base.toml around lines 1075-1083 and compare the corresponding change from issue #2108 for gimlet. Check nearby device sensor definitions for other matching omissions, then run the relevant Hubris build or validation to confirm the cosmo temperature sensors are present.

Written by the indexing model from the issue text.

Description

#2108 added the missing temperature sensors for gimlet, but cosmo is also missing them:

https://github.com/oxidecomputer/hubris/blob/b931e44d5e340a5dfda2c02153507db1bfa38ed1/app/cosmo/base.toml#L1075-L1083

I'll make a similar change for cosmo, and see if there are any other similar items.

It seems somewhat unfortunate that this needs to be done on a per-device basis, however I'm unsure of other feasible approaches we could take.

Dominant language
Rust
Stars
3.6k
Forks
239
Avg merge
1d 12h
Merged PRs (30d)
23

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/hubris

All issues in oxidecomputer/hubris

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.