oxidecomputer / oxidecomputer/hubris
there are two SprotErrors, no relation
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
$ pfexec /tmp/humility hiffy -c SpRot.status
humility: attached to 0483:3754:003300324741500820383733 via ST-Link V3
humility hiffy failed: SprotError matches more than one enum: attest_data::messages::SprotError as GOFF 0x00039350 (object 21), drv_sprot_api::error::SprotError as GOFF 0x00044a4a (object 21)
$ /tmp/humility --version
humility 0.11.11
In this case I'm looking for drv_sprot_api::error::SprotError, but it seems that the phonebook now contains an attest_data::messages::SprotError as well. Bryan suggests that we usually correct this condition by qualifying stuff in the idol files?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the ambiguity with the hiffy -c SpRot.status command, then inspect the idol definitions for attest_data::messages::SprotError and drv_sprot_api::error::SprotError. Determine how idol qualification affects the phonebook lookup; done means the intended drv_sprot_api::error::SprotError resolves unambiguously.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100