oxidecomputer / oxidecomputer/hubris
Inconsistencies in tech port unlock behavior
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
control-plane-agent and net store unlock state on a per-VLAN basis. However, monorail does not; it enables all tech ports when unlocked. This could be confusing if someone sends unlock commands on multiple ports; monorail's time-based unlock will fire at the time set by the most recent unlock.
We should either
- Make
monorailsmarter (configuring the VLANs to enable one or both tech ports, instead of always enabling both), or - Make the other tasks dumber, with a single locked / unlocked state controlling their behavior
I'm leaning towards the latter, because it's hard to imagine a case where someone authorized is connected to TP1 and someone malicious is connected to TP2.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing unlock-state handling in control-plane-agent, net, and monorail, focusing on how VLANs and the two tech ports respond to unlock commands. Resolve whether the shared behavior should be per-VLAN or global, then verify that commands on multiple ports produce consistent locking and time-based unlock behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100