oxidecomputer / oxidecomputer/hubris

Use RangeInclusive in ../image.rs to be able to model images at the end of the u32 address space.

Open
#1,836 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
3.6k
Forks
239
Avg merge
1d 12h
Merged PRs (30d)
23

Description

Comment on PR #1813 from Cliff:
"Not a problem in our current address space layout, but in general it seems like these should be RangeInclusive --- otherwise they can't model a range at the end of the u32 space."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open ../image.rs and locate the image address ranges described in the issue. Check how they are represented and confirm that the inclusive form can model ranges ending at the end of the u32 address space without changing current behavior. Done means the relevant ranges use RangeInclusive and the Rust checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
embedded-iot, operating-systems
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.