oxidecomputer / oxidecomputer/hubris

`thermal` shouldn't be so twitchy

Open
#1,785 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

thermal 🚫🔥🚫
Dominant language
Rust
Stars
3.6k
Forks
239
Avg merge
1d 12h
Merged PRs (30d)
23

Description

If a single measurement comes in over the high input limit, the thermal loop will disable the system. This is aggressive and can cause the system to shutdown with a spurious measurement.

For example, consider this ringbuf that shows a system sitting with 0% PWM and then being shut down due to a single spurious measurement:

  27  982        4     4328 ControlPwm(0x0)
  28  897        4        1 AutoState(Uncontrollable)
  29  986        4        1 PowerDownAt(0x49f6e3)
  30  770        4        1 PowerModeChanged(PowerBitmask(0b1))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the thermal loop and its high input limit handling in the repository, then inspect how the ringbuf events lead to shutdown. Reproduce the single-spurious-measurement scenario if possible; done should mean one high measurement no longer immediately disables or shuts down the system.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.