oxidecomputer / oxidecomputer/hubris
Sensor model needs expansion for multichannel sensors
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
Currently, the way sensors -- which in practice right now means "PMBus sensors" -- are defined assumes that a given sensor device has a single output channel of each kind. Voltage, power, current, temperature, etc.
This kind of works, but doesn't describe all devices, and in particular doesn't describe all devices we are currently shipping.
This is a placeholder issue to remind us of this. Ideally we would be able to have multiple named channels of each unit type per device, so we could distinguish e.g. "die temperature" from "cpu0 temperature" (hypothetically, not a real device) or "power in" from "power out" on the RAA229618 (which is real and can be important for computing overhead/loss).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by locating the current PMBus sensor model and reviewing the shipped devices that need multiple outputs; done should support multiple named channels for each unit type, including distinctions such as die versus CPU temperature and power input versus output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- embedded-iot
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100