oxidecomputer / oxidecomputer/hubris
Build system doesn't detect changes in files included by app.toml reliably.
Open
Nobody has claimed this yet.
build
- Dominant language
- Rust
- Stars
- 3.6k
- Forks
- 239
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 23
Description
I noticed today that if you do this:
- Build an app (say,
app/rot-carrier/app.tomlsince that's what I was building) - Modify the memory definition it uses (in this case,
chips/lpc55/memory.toml) - Build the app again
...the changes are not reflected. This makes the build incorrect. However the pseudo-includes to app.toml are implemented, they do not appear to be implemented in a way that feeds into the change detection logic, and this needs to be fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the build logic that processes app/rot-carrier/app.toml and its pseudo-includes, using chips/lpc55/memory.toml as the reproduced dependency. First trace how included files enter change detection; done means rebuilding after a memory.toml change reliably reflects the updated definition.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100