oxidecomputer / oxidecomputer/helios

Dig into potential issue with tokio start_paused

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
481
Forks
21
Avg merge
1d 17h
Merged PRs (30d)
2

Description

In https://github.com/oxidecomputer/omicron/pull/2654 we found that a test with tokio::test(start_paused = true) that consistently worked on Linux was flaky on illumos.

Note that start_paused = true runs tokio in a mode where timers are paused, and auto-advance. Since all this code uses Tokio, pausing and auto-advancing timers should work in theory -- there's no reason for any of these operations to be tied to system timers.

This could be any of the following:

  • an omicron code difference between Linux and illumos (though the test doesn't use any illumos-specific features and is completely OS-independent -- it uses MGS talking to sp-sim).
  • a scheduler difference on illumos compared to Linux
  • a Tokio difference between illumos on Linux
  • a bug in Tokio

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the flaky test described in omicron PR #2654 and reproduce it on Linux and illumos. Compare the behavior of Tokio's start_paused = true mode and the OS scheduler, while checking for omicron-specific differences. Done means identifying the source of the discrepancy and documenting or fixing the underlying issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems, testing-qa
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.