oxidecomputer / oxidecomputer/helios

rust minimum version needs to be bumped

Open
#142 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
481
Forks
21
Avg merge
1d 17h
Merged PRs (30d)
2

Description

While building on a system that had a slightly older toolchain, I noticed the following build error:

$ gmake setup
cd tools/helios-build && cargo build --quiet
error[E0658]: use of unstable library feature 'is_terminal'
 --> src/common.rs:8:5
  |
8 | use std::io::IsTerminal;
  |     ^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #98070 <https://github.com/rust-lang/rust/issues/98070> for more information

error[E0658]: use of unstable library feature 'is_terminal'
  --> src/common.rs:20:26
   |
20 |     if std::io::stdout().is_terminal() {
   |                          ^^^^^^^^^^^
   |
   = note: see issue #98070 <https://github.com/rust-lang/rust/issues/98070> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `helios-build` due to 2 previous errors

It appears that the minimum version needs to be bumped to something like 1.70 per https://github.com/rust-lang/rust/releases/tag/1.70.0.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running gmake setup and inspect the Rust configuration for tools/helios-build, then review src/common.rs, where the IsTerminal API causes the reported error. Update the declared minimum Rust version to the version required by this API, such as 1.70, and confirm that the setup build succeeds with that toolchain.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.