oxidecomputer / oxidecomputer/helios
gmake setup could probably succeed in bldenv
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 481
- Forks
- 21
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 2
Description
I accidentally had a shell in a screen session in a bldenv environment. I had kicked off a gmake setup and came back hours later when getting back around to it (not because gmake setup takes that long) and found it failed:
rm@iliad:/ws/rm/ar$ gmake setup
cd tools/helios-build && cargo build --quiet
Error: helios-build should not run from within the bldenv shell
While I appreciate that this makes sense when nested for other operations in terms of building illumos, maybe the gmake setup could succeed?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the gmake setup target and the tools/helios-build entry point, focusing on the bldenv check shown in the failure output. Determine how setup behaves inside bldenv without disrupting the existing nested-build protection. Done means gmake setup succeeds from a bldenv shell while the relevant safety behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100