oxidecomputer / oxidecomputer/helios-rot
helios-rot: attestation variant for p384 must include the digest function
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The P384 variant in the Attestation type https://github.com/oxidecomputer/dice-util/blob/d4c761370597e7476782c1225b70505142ead378/helios-rot/src/lib.rs#L60 assumes that the Sha2_384 digest is being used. This is the default for the p384 crate, and the recommendation from NIST. But use of Sha3_384 is allowed, as is the 512 variants. Use digest algorithms with smaller output is possible but discouraged. We need to add an identifier for the hash digest to the variants in this enum.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read helios-rot/src/lib.rs at the Attestation type and its P384 variant first. Add an identifier for the digest algorithm so the variant no longer assumes Sha2_384 and can represent the permitted Sha3_384 and 512 variants; done means the enum records that digest choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cryptography
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 56/100