oxidecomputer / oxidecomputer/falcon
Use propolis client directly for serial console
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 20
- Forks
- 5
- Avg merge
- 11d 13h
- Merged PRs (30d)
- 2
Description
The following code is copy pasta from the propolis client implementation with a small modification to use ^q for escaping the serial session (and thereby allowing ^c through to the VM)
https://github.com/oxidecomputer/falcon/blob/main/lib/src/cli.rs#L406-L543
Now that the propolis client CLI machinery is getting a configurable escape sequence, we can just use that implementation directly and configure the tunable escape sequence to be ^q to maintain the current falcon behavior.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/src/cli.rs around lines 406-543 and compare Falcon's copied serial-console implementation with the propolis client implementation. Review the configurable escape sequence introduced by propolis PR 297, then make Falcon use the client directly while retaining ^q as its configured escape sequence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100