oxidecomputer / oxidecomputer/falcon

serial console error message on node that is not running is unhelpful

Open
#295 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
20
Forks
5
Avg merge
11d 13h
Merged PRs (30d)
2

Description

If an instance is not running for some reason and an attempt to get a serial console is made, we get the following.

$ ./solo serial turbolift
Entering VM console.
Use ^q to exit.
Press enter to continue.
Error: Anyhow(failed to create serial websocket stream

Caused by:
    HTTP error: 200 OK)

Which is not at all helpful.

This can be reproduced as follows with a simple one node topology.

use libfalcon::{cli::run, error::Error, unit::gb, Runner};

#[tokio::main]
async fn main() -> Result<(), Error> {
    let mut d = Runner::new("solo");

    // nodes
    let turbolift = d.node("turbolift", "helios-2.9", 8, gb(8));
    run(&mut d).await?;

    Ok(())
}
pfexec ./solo launch
# wait for topology to come up
pfexec pkill propolis-server
./solo serial turbolift

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ./solo serial command and trace the failed serial websocket stream shown in the report. Reproduce it after stopping propolis-server, then make the error identify that the node is not running and verify the serial command reports that condition clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.