oxidecomputer / oxidecomputer/falcon

store FALCON_DATASET (and other env vars) so they can't get out of sync

Open
#107 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
20
Forks
5
Avg merge
11d 13h
Merged PRs (30d)
2

Description

The failure mode I ran into is that I tore down an a4x2 deployment, then started a new one that I expected to be a clean slate, but at least on g0 it had all of the state from the previous run's internal zpools. I don't know for sure what happened. But I normally set FALCON_DATASET when using a4x2 and I suspect that I neglected to set FALCON_DATASET for this invocation of a4x2 destroy and it tried to destroy the wrong datasets. It would be nice the tool recorded the locations of these datasets (like it does a lot of the other configuration) rather than relying on the user to consistently set it each time the command is run.

I'm not sure if this is also the cause of #67.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the a4x2 destroy invocation and how FALCON_DATASET and other environment variables are currently read, then inspect the existing configuration-recording behavior mentioned in the issue. Clarify which dataset locations must be persisted and how a new deployment should distinguish them from a previous run. Done means destroy uses the recorded locations rather than relying on each invocation's environment variables, with the suspected stale-state scenario covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devops, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.