oxidecomputer / oxidecomputer/dropshot

Test that max request body size is enforced for chunked encoding

Open
#545 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
104
Avg merge
1d 19h
Merged PRs (30d)
22

Description

HTTP does not specify a limit on request body size but allows implementations to enforce one to allow bounding of resource usage. When chunked encoding is used, the request body length is not known upfront and is only known incrementally as each chunk is received. Dropshot has a config option to set a maximum request body size but no test to verify that that limit is enforced when chunked encoding is used and a steady stream of chunks, each individually smaller than the limit, are received.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the maximum request body size configuration and the chunked request handling. Add coverage for a steady stream of chunks where each chunk is below the limit but the cumulative body exceeds it, then run the relevant request-body tests and verify the request is rejected.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend, testing
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.