oxidecomputer / oxidecomputer/dropshot
move functionality of RequestContext::page_limit() to PaginationParams::limit()?
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 104
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 22
Description
It might be more intuitive to look for the limit from PaginationParams and since the limit field itself is not accessible (or documented publicly) a method there might be more easily found than in RequestContext
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating RequestContext::page_limit() and PaginationParams, then inspect how the limit field is exposed and used. Determine whether the lookup can move to PaginationParams without changing pagination behavior, and verify that callers and relevant tests still pass with the new public method.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100