oxidecomputer / oxidecomputer/dropshot

LogContext paths could be more unique

Open
#479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
104
Avg merge
1d 19h
Merged PRs (30d)
22

Description

See oxidecomputer/omicron#1936. We should consider more unique log file names.

We should also provide a more useful error message here. The use of unwrap() means we get little information about what we were trying to do. It shouldn't be necessary to look at the code to figure out what happened here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read oxidecomputer/omicron#1936 first, then locate the LogContext path construction and the unwrap() mentioned in this issue. Confirm the expected filename uniqueness and error details before changing behavior; done means log files are more distinguishable and failures explain what operation was attempted.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.