oxidecomputer / oxidecomputer/dropshot
Raise a build time error for nested structs with URL-encoded bodies
Open
@plotnick is already working on this.
Since Jun 22, 2022.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 104
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 22
Description
serde_urlencoded produces a runtime error if asked to decode a nested struct. We could detect that at build time by looking at the JsonSchema object and making sure it's an object whose properties are all scalars. See https://github.com/oxidecomputer/dropshot/pull/363#pullrequestreview-1014110275.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.