oxidecomputer / oxidecomputer/dropshot
Update to Rust 2024 Edition / MSRV of 1.85
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 104
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 22
Description
Proposing updating Dropshot to Rust 2024 Edition and explicitly specifying 1.85 as MSRV.
I would propose this is done as distinct PRs:
-
PR with Automated formatting and edition changes:
cargo fix --editionandcargo fmtwithstyle_edition = 2024inrustfmt.toml. https://github.com/oxidecomputer/dropshot/pull/1605 -
PR which:
a. Changes the Cargo.toml edition to 2024
b. Expands the CI matrix to run under a "current" rust version (rust-toolchain.toml) and under the MSRV (rust 1.85) -
PR adding
.git-blame-ignore-revsto ignore the commit hash from the first PR.
GitHub will automatically pickup .git-blame-ignore-revs when calculating blame (no config required). I usually add instructions to the file to for how to configure git locally (like this one).
Thoughts?
CC: @ahl @sunshowers
Prior work:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the proposed changes in Cargo.toml, rust-toolchain.toml, rustfmt.toml, and the CI configuration. Review PR 1605 and the prior PR 1439 before running cargo fix --edition and cargo fmt. Done means Rust 2024 is configured, MSRV 1.85 and current Rust are tested in CI, and .git-blame-ignore-revs records the formatting commit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, ci-cd
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100